Skip to content

BUGFIX: Reset accidentally upmerged branch version constraints#3412

Merged
mficzel merged 2 commits intoneos:masterfrom
mficzel:bugfix/resetAccidentallyUpmergedBranchVersionConstraints
Aug 17, 2021
Merged

BUGFIX: Reset accidentally upmerged branch version constraints#3412
mficzel merged 2 commits intoneos:masterfrom
mficzel:bugfix/resetAccidentallyUpmergedBranchVersionConstraints

Conversation

@mficzel
Copy link
Member

@mficzel mficzel commented Aug 16, 2021

Some constraints of the 7.1 branch seem to have been accidentally upmerged to master.
This change reset those to dev-master again.

Some constraints of the 7.1 branch have been accidentally upmerged to master. This change reset those to dev-master.
@mficzel mficzel requested review from albe and kdambekalns August 16, 2021 16:21
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that was caused by 42771e2#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34 and has been there for quite some time… 🙈

@mficzel
Copy link
Member Author

mficzel commented Aug 16, 2021

Jenkins did that correctly for 7.1 ... only problem is that is was later merged back to master. Maybe we can prevent that by immediately merging new branches back to master in future (without the adjusted version requirements).

@albe
Copy link
Contributor

albe commented Aug 17, 2021

Maybe we can prevent that by immediately merging new branches back to master in future (without the adjusted version requirements).

Yes - had the same idea in slack not so long ago. Should work seemless to do this inside the create-branch scripts

@mficzel mficzel merged commit 070a313 into neos:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants