neos · mhsdesign · Dec 12, 2025 · Apr 4, 2025 · Apr 4, 2025 · Apr 4, 2025
diff --git a/Neos.Flow.Log/Classes/Backend/AbstractBackend.php b/Neos.Flow.Log/Classes/Backend/AbstractBackend.php
@@ -42,7 +42,7 @@ abstract class AbstractBackend implements BackendInterface
      */
     public function __construct($options = [])
     {
-        if (is_array($options) || $options instanceof \ArrayAccess) {
+        if (is_iterable($options)) {
             foreach ($options as $optionKey => $optionValue) {
                 $methodName = 'set' . ucfirst($optionKey);
                 if (method_exists($this, $methodName)) {

diff --git a/Neos.Flow.Log/Classes/Backend/AnsiConsoleBackend.php b/Neos.Flow.Log/Classes/Backend/AnsiConsoleBackend.php
@@ -40,7 +40,7 @@ class AnsiConsoleBackend extends ConsoleBackend
     const END = "\033[0m";
 
     /**
-     * @var array
+     * @var array<string,string>
      */
     protected $tagFormats = [];
 
@@ -75,12 +75,7 @@ public function open(): void
     /**
      * Appends the given message along with the additional information into the log.
      *
-     * @param string $message
-     * @param int $severity
-     * @param array $additionalData
-     * @param string $packageKey
-     * @param string $className
-     * @param string $methodName
+     * @param array<mixed>|null $additionalData
      * @return void
      */
     public function append(string $message, int $severity = LOG_INFO, $additionalData = null, ?string $packageKey = null, ?string $className = null, ?string $methodName = null): void
@@ -118,15 +113,15 @@ protected function formatOutput($output)
                 } else {
                     return str_replace('|', $matches[3], $format);
                 }
-            }, $output);
+            }, $output) ?: '';
         } while ($lastOutput !== $output);
         return $output;
     }
 
     /**
      * @param boolean $disableAnsi
      */
-    public function setDisableAnsi($disableAnsi)
+    public function setDisableAnsi($disableAnsi): void
     {
         $this->disableAnsi = $disableAnsi;
     }

diff --git a/Neos.Flow.Log/Classes/Backend/ConsoleBackend.php b/Neos.Flow.Log/Classes/Backend/ConsoleBackend.php
@@ -25,7 +25,7 @@ class ConsoleBackend extends AbstractBackend
 {
     /**
      * An array of severity labels, indexed by their integer constant
-     * @var array
+     * @var array<int,string>
      */
     protected $severityLabels;
 
@@ -61,10 +61,11 @@ public function open(): void
             LOG_DEBUG => 'DEBUG    ',
         ];
 
-        $this->streamHandle = fopen('php://' . $this->streamName, 'w');
-        if (!is_resource($this->streamHandle)) {
+        $streamHandle = fopen('php://' . $this->streamName, 'w');
+        if (!is_resource($streamHandle)) {
             throw new CouldNotOpenResourceException('Could not open stream "' . $this->streamName . '" for write access.', 1310986609);
         }
+        $this->streamHandle = $streamHandle;
     }
 
     /**

diff --git a/Neos.Flow.Log/Classes/Backend/FileBackend.php b/Neos.Flow.Log/Classes/Backend/FileBackend.php
@@ -27,7 +27,7 @@ class FileBackend extends AbstractBackend
 {
     /**
      * An array of severity labels, indexed by their integer constant
-     * @var array
+     * @var array<int,string>
      */
     protected $severityLabels;
 
@@ -192,6 +192,9 @@ public function open(): void
     protected function rotateLogFile(): void
     {
         $lockResource = fopen($this->logFileUrl . '.lock', 'w+');
+        if ($lockResource === false) {
+            throw new \RuntimeException(sprintf('Fatal: cannot open/create file "%s".', $this->logFileUrl . '.lock'), 1765550110);
+        }
 
         $exclusiveNonBlockingLockResult = flock($lockResource, LOCK_EX | LOCK_NB);
         if ($exclusiveNonBlockingLockResult === false) {

diff --git a/Neos.Flow.Log/Classes/PlainTextFormatter.php b/Neos.Flow.Log/Classes/PlainTextFormatter.php
@@ -22,8 +22,8 @@ public function __construct($variable)
     }
 
     /**
-     * @param $spaces
-     * @return string
+     * @param int $spaces
+     * @return ?string
      */
     public function format($spaces = 4)
     {

diff --git a/Neos.Flow.Log/Classes/Psr/Logger.php b/Neos.Flow.Log/Classes/Psr/Logger.php
@@ -45,7 +45,7 @@ class Logger implements LoggerInterface
     /**
      * Constructs the PSR-3 Logger.
      *
-     * @param iterable $backends
+     * @param iterable<mixed> $backends
      */
     public function __construct(iterable $backends)
     {
@@ -61,7 +61,7 @@ public function __construct(iterable $backends)
     /**
      * @param mixed $level
      * @param string|\Stringable $message
-     * @param array $context
+     * @param array<string,mixed> $context
      * @api
      */
     public function log($level, string|\Stringable $message, array $context = []): void
@@ -80,8 +80,8 @@ public function log($level, string|\Stringable $message, array $context = []): v
     }
 
     /**
-     * @param array $context
-     * @return array list of packageKey, className and methodName either string or null
+     * @param array<string,mixed> $context
+     * @return array<int,string|null> list of packageKey, className and methodName either string or null
      */
     protected function extractLegacyDataFromContext(array $context): array
     {
@@ -93,8 +93,8 @@ protected function extractLegacyDataFromContext(array $context): array
     }
 
     /**
-     * @param array $context
-     * @return array
+     * @param array<string,mixed> $context
+     * @return array<string,mixed>
      */
     protected function removeLegacyDataFromContext(array $context): array
     {

diff --git a/Neos.Flow/Classes/Reflection/ReflectionService.php b/Neos.Flow/Classes/Reflection/ReflectionService.php
@@ -325,8 +325,9 @@ public function getAllImplementationClassNamesForInterface(string $interfaceName
      * Searches for and returns all names of classes inheriting the specified class.
      * If no class inheriting the given class was found, an empty array is returned.
      *
-     * @param class-string $className
-     * @return array<class-string>
+     * @template T of object
+     * @param class-string<T> $className
+     * @return list<class-string<T>>
      * @throws ClassLoadingForReflectionFailedException
      * @throws InvalidClassException
      * @throws \ReflectionException

diff --git a/Neos.FluidAdaptor/Classes/Core/Cache/CacheAdaptor.php b/Neos.FluidAdaptor/Classes/Core/Cache/CacheAdaptor.php
@@ -49,6 +49,7 @@ public function get($name)
      *
      * @param string $name
      * @param string $value
+     * @return void
      */
     public function set($name, $value)
     {

diff --git a/Neos.FluidAdaptor/Classes/Core/Parser/Interceptor/ResourceInterceptor.php b/Neos.FluidAdaptor/Classes/Core/Parser/Interceptor/ResourceInterceptor.php
@@ -97,7 +97,7 @@ public function process(NodeInterface $node, $interceptorPosition, ParsingState
         if (strpos($node->getText(), 'Public/') === false) {
             return $node;
         }
-        $textParts = preg_split(self::PATTERN_SPLIT_AT_RESOURCE_URIS, $node->getText(), -1, PREG_SPLIT_NO_EMPTY | PREG_SPLIT_DELIM_CAPTURE);
+        $textParts = preg_split(self::PATTERN_SPLIT_AT_RESOURCE_URIS, $node->getText(), -1, PREG_SPLIT_NO_EMPTY | PREG_SPLIT_DELIM_CAPTURE) ?: [];
         $node = new RootNode();
         foreach ($textParts as $part) {
             $matches = [];
@@ -109,7 +109,7 @@ public function process(NodeInterface $node, $interceptorPosition, ParsingState
                 if ($this->defaultPackageKey !== null) {
                     $arguments['package'] = new TextNode($this->defaultPackageKey);
                 }
-                if (isset($matches['Package']) && FlowPackageKey::isPackageKeyValid($matches['Package'])) {
+                if (FlowPackageKey::isPackageKeyValid($matches['Package'])) {
                     $arguments['package'] = new TextNode($matches['Package']);
                 }
 
@@ -127,7 +127,7 @@ public function process(NodeInterface $node, $interceptorPosition, ParsingState
     /**
      * This interceptor wants to hook into text nodes.
      *
-     * @return array Array of INTERCEPT_* constants
+     * @return array<int,int> Array of INTERCEPT_* constants
      */
     public function getInterceptionPoints()
     {

diff --git a/....FluidAdaptor/Classes/Core/Parser/SyntaxTree/Expression/LegacyNamespaceExpressionNode.php b/....FluidAdaptor/Classes/Core/Parser/SyntaxTree/Expression/LegacyNamespaceExpressionNode.php
@@ -24,14 +24,14 @@ class LegacyNamespaceExpressionNode extends AbstractExpressionNode implements Ex
      * Pattern which detects namespace declarations made inline.
      * syntax, e.g. {namespace neos=TYPO3\Neos\ViewHelpers}.
      */
-    public static $detectionExpression = '/{namespace\\s*([a-z0-9]+)\\s*=\\s*([a-z0-9_\\\\]+)\\s*}/i';
+    public static string $detectionExpression = '/{namespace\\s*([a-z0-9]+)\\s*=\\s*([a-z0-9_\\\\]+)\\s*}/i';
 
     /**
      * Evaluates the expression stored in this node, in the context of $renderingcontext.
      *
      * @param RenderingContextInterface $renderingContext
      * @param string $expression
-     * @param array $matches
+     * @param array<int,mixed> $matches
      * @return mixed
      */
     public static function evaluateExpression(RenderingContextInterface $renderingContext, $expression, array $matches)

diff --git a/Neos.FluidAdaptor/Classes/Core/Parser/SyntaxTree/ResourceUriNode.php b/Neos.FluidAdaptor/Classes/Core/Parser/SyntaxTree/ResourceUriNode.php
@@ -35,18 +35,18 @@ class ResourceUriNode extends ViewHelperNode
     protected $viewHelperResolver;
 
     /**
-     * @var string
+     * @var class-string<ResourceViewHelper>
      */
     protected $viewHelperClassName = ResourceViewHelper::class;
 
     /**
      * @param ViewHelperResolver $viewHelperResolver
+     * @return void
      */
     public function injectViewHelperResolver(ViewHelperResolver $viewHelperResolver)
     {
         $this->viewHelperResolver = $viewHelperResolver;
         $this->uninitializedViewHelper = $this->viewHelperResolver->createViewHelperInstanceFromClassName($this->viewHelperClassName);
-        /** @phpstan-ignore-next-line we use internal api */
         $this->uninitializedViewHelper->setViewHelperNode($this);
         $this->argumentDefinitions = $this->viewHelperResolver->getArgumentDefinitionsForViewHelper($this->uninitializedViewHelper);
     }

diff --git a/Neos.FluidAdaptor/Classes/Core/Parser/TemplateParser.php b/Neos.FluidAdaptor/Classes/Core/Parser/TemplateParser.php
@@ -16,6 +16,7 @@ public function isEscapingEnabled()
 
     /**
      * @param boolean $escapingEnabled
+     * @return void
      */
     public function setEscapingEnabled($escapingEnabled)
     {

diff --git a/Neos.FluidAdaptor/Classes/Core/Parser/TemplateProcessor/EscapingFlagProcessor.php b/Neos.FluidAdaptor/Classes/Core/Parser/TemplateProcessor/EscapingFlagProcessor.php
@@ -25,10 +25,11 @@ class EscapingFlagProcessor implements TemplateProcessorInterface
      */
     protected $renderingContext;
 
-    public static $SCAN_PATTERN_ESCAPINGMODIFIER = '/{escapingEnabled\s*=\s*(?P<enabled>true|false)\s*}/i';
+    public static string $SCAN_PATTERN_ESCAPINGMODIFIER = '/{escapingEnabled\s*=\s*(?P<enabled>true|false)\s*}/i';
 
     /**
      * @param RenderingContextInterface $renderingContext
+     * @return void
      */
     public function setRenderingContext(RenderingContextInterface $renderingContext)
     {
@@ -56,7 +57,7 @@ public function preProcessSource($templateSource)
         if (strtolower($matches[0]['enabled']) === 'false') {
             $this->renderingContext->getTemplateParser()->setEscapingEnabled(false);
         }
-        $templateSource = preg_replace(self::$SCAN_PATTERN_ESCAPINGMODIFIER, '', $templateSource);
+        $templateSource = preg_replace(self::$SCAN_PATTERN_ESCAPINGMODIFIER, '', $templateSource) ?: '';
 
         return $templateSource;
     }

diff --git a/...luidAdaptor/Classes/Core/Parser/TemplateProcessor/NamespaceDetectionTemplateProcessor.php b/...luidAdaptor/Classes/Core/Parser/TemplateProcessor/NamespaceDetectionTemplateProcessor.php
@@ -29,7 +29,7 @@ class NamespaceDetectionTemplateProcessor extends FluidNamespaceDetectionTemplat
     /**
      * Extension of the default pattern for dynamic tags including namespaces with uppercase letters.
      */
-    public static $EXTENDED_SPLIT_PATTERN_TEMPLATE_DYNAMICTAGS = '/
+    public static string $EXTENDED_SPLIT_PATTERN_TEMPLATE_DYNAMICTAGS = '/
 		(
 			(?: <\/?                                      # Start dynamic tags
 					(?:(?:[a-zA-Z0-9\\.]*):[a-zA-Z0-9\\.]+)  # A tag consists of the namespace prefix and word characters
@@ -75,7 +75,7 @@ public function preProcessSource($templateSource)
      */
     public function protectCDataSectionsFromParser(string $templateSource)
     {
-        $parts = preg_split('/(\<\!\[CDATA\[|\]\]\>)/', $templateSource, -1, PREG_SPLIT_DELIM_CAPTURE);
+        $parts = preg_split('/(\<\!\[CDATA\[|\]\]\>)/', $templateSource, -1, PREG_SPLIT_DELIM_CAPTURE) ?: [];
         $balance = 0;
         $content = '';
         $resultingParts = [];
@@ -127,7 +127,7 @@ public function protectCDataSectionsFromParser(string $templateSource)
     public function throwExceptionsForUnhandledNamespaces(string $templateSource): void
     {
         $viewHelperResolver = $this->renderingContext->getViewHelperResolver();
-        $splitTemplate = preg_split(static::$EXTENDED_SPLIT_PATTERN_TEMPLATE_DYNAMICTAGS, $templateSource, -1, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY);
+        $splitTemplate = preg_split(static::$EXTENDED_SPLIT_PATTERN_TEMPLATE_DYNAMICTAGS, $templateSource, -1, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY) ?: [];
         foreach ($splitTemplate as $templateElement) {
             if (preg_match(Patterns::$SCAN_PATTERN_TEMPLATE_VIEWHELPERTAG, $templateElement, $matchedVariables) > 0) {
                 if (!$viewHelperResolver->isNamespaceValidOrIgnored($matchedVariables['NamespaceIdentifier'])) {
@@ -148,11 +148,9 @@ public function throwExceptionsForUnhandledNamespaces(string $templateSource): v
             foreach ($sections as $section) {
                 if (preg_match(Patterns::$SCAN_PATTERN_SHORTHANDSYNTAX_OBJECTACCESSORS, $section, $matchedVariables) > 0) {
                     preg_match_all(Patterns::$SPLIT_PATTERN_SHORTHANDSYNTAX_VIEWHELPER, $section, $shorthandViewHelpers, PREG_SET_ORDER);
-                    if (is_array($shorthandViewHelpers) === true) {
-                        foreach ($shorthandViewHelpers as $shorthandViewHelper) {
-                            if (!$viewHelperResolver->isNamespaceValidOrIgnored($shorthandViewHelper['NamespaceIdentifier'])) {
-                                throw new UnknownNamespaceException('Unknown Namespace: ' . $shorthandViewHelper['NamespaceIdentifier']);
-                            }
+                    foreach ($shorthandViewHelpers as $shorthandViewHelper) {
+                        if (!$viewHelperResolver->isNamespaceValidOrIgnored($shorthandViewHelper['NamespaceIdentifier'])) {
+                            throw new UnknownNamespaceException('Unknown Namespace: ' . $shorthandViewHelper['NamespaceIdentifier']);
                         }
                     }
                 }

diff --git a/Neos.FluidAdaptor/Classes/Core/Rendering/RenderingContext.php b/Neos.FluidAdaptor/Classes/Core/Rendering/RenderingContext.php
@@ -25,6 +25,7 @@
 use Neos\FluidAdaptor\Core\ViewHelper\ViewHelperResolver;
 use Neos\FluidAdaptor\View\TemplatePaths;
 use TYPO3Fluid\Fluid\Core\Parser\Configuration;
+use TYPO3Fluid\Fluid\Core\Parser\SyntaxTree\Expression\AbstractExpressionNode;
 use TYPO3Fluid\Fluid\Core\Parser\SyntaxTree\Expression\CastingExpressionNode;
 use TYPO3Fluid\Fluid\Core\Parser\SyntaxTree\Expression\MathExpressionNode;
 use TYPO3Fluid\Fluid\Core\Parser\SyntaxTree\Expression\TernaryExpressionNode;
@@ -42,7 +43,7 @@ class RenderingContext extends FluidRenderingContext implements FlowAwareRenderi
      * which will be consulted when an expression does not match
      * any built-in parser expression types.
      *
-     * @var array
+     * @var array<class-string<AbstractExpressionNode>>
      */
     protected $expressionNodeTypes = [
         LegacyNamespaceExpressionNode::class,
@@ -81,7 +82,7 @@ class RenderingContext extends FluidRenderingContext implements FlowAwareRenderi
     /**
      * RenderingContext constructor.
      *
-     * @param array $options
+     * @param array<string,mixed> $options
      */
     public function __construct(array $options = [])
     {
@@ -99,6 +100,7 @@ public function __construct(array $options = [])
 
     /**
      * @param ObjectManagerInterface $objectManager
+     * @return void
      */
     public function injectObjectManager(ObjectManagerInterface $objectManager)
     {
@@ -116,7 +118,7 @@ public function getControllerContext()
     /**
      * @param ControllerContext $controllerContext
      */
-    public function setControllerContext($controllerContext)
+    public function setControllerContext($controllerContext): void
     {
         $this->controllerContext = $controllerContext;
         $request = $controllerContext->getRequest();

diff --git a/Neos.FluidAdaptor/Classes/Core/ViewHelper/AbstractConditionViewHelper.php b/Neos.FluidAdaptor/Classes/Core/ViewHelper/AbstractConditionViewHelper.php
@@ -45,6 +45,7 @@ abstract class AbstractConditionViewHelper extends AbstractViewHelper
 
     /**
      * Initializes the "then" and "else" arguments
+     * @return void
      */
     public function initializeArguments()
     {
@@ -66,18 +67,19 @@ public function initializeArguments()
      * subclasses that will be using this base class in the future. Let this
      * be a warning if someone considers changing this method signature!
      *
-     * @param array|NULL $arguments
+     * @param array<mixed>|NULL $arguments
      * @param RenderingContextInterface $renderingContext
      * @return boolean
      * @api
      */
     protected static function evaluateCondition($arguments, RenderingContextInterface $renderingContext)
     {
-        return (boolean)$arguments['condition'];
+        // fallback value derived from registerArgument default value
+        return (boolean)($arguments['condition'] ?? false);
     }
 
     /**
-     * @param array $arguments
+     * @param array<string,mixed> $arguments
      * @param \Closure $renderChildrenClosure
      * @param RenderingContextInterface $renderingContext
      * @return mixed
@@ -103,8 +105,8 @@ public static function renderStatic(array $arguments, \Closure $renderChildrenCl
     }
 
     /**
-     * @param array $closures
-     * @param array $conditionClosures
+     * @param array<mixed> $closures
+     * @param array<mixed> $conditionClosures
      * @param RenderingContextInterface $renderingContext
      * @return string
      */
@@ -236,7 +238,7 @@ public function compile($argumentsName, $closureName, &$initializationPhpCode, V
 
     /**
      * @param boolean $isConditionFullfilled
-     * @param array $arguments
+     * @param array<string,mixed> $arguments
      * @param RenderingContextInterface $renderingContext
      * @return mixed
      */
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,6 +16,7 @@ public function isEscapingEnabled() @@
         /**
          * @param boolean $escapingEnabled
+         * @return void
          */
         public function setEscapingEnabled($escapingEnabled)
         {
@@ Expand Down @@