Skip to content

TASK: Adjust docblock typehint to TYPO3Fluid change #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albe merged 2 commits into from
Nov 22, 2021
Merged

TASK: Adjust docblock typehint to TYPO3Fluid change #2633

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1f71e4
TASK: Adjust docblock typehint to TYPO3Fluid change
albe Nov 22, 2021
84b012f
TASK: Cast possible null to empty string in createIdentifierForFile
albe Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Neos.FluidAdaptor/Classes/View/TemplatePaths.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,13 +539,14 @@ public function setOption($optionName, $value)
* <PackageKey>_<SubPackageKey>_<ControllerName>_<prefix>_<SHA1>
* The SH1 hash is a checksum that is based on the file path and last modification date
*
* @param string $pathAndFilename
* @param string|null $pathAndFilename
* @param string $prefix
* @return string
* @throws InvalidTemplateResourceException
*/
protected function createIdentifierForFile($pathAndFilename, $prefix)
{
$pathAndFilename = (string)$pathAndFilename;
Copy link
Contributor Author

@albe albe Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meh, but that's what TYPO3Fluid does too.

Copy link
Member

@bwaidelich bwaidelich Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o.O I wonder why they changed the param annotation then.. well

Copy link
Contributor Author

@albe albe Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

$templateModifiedTimestamp = 0;
$isStandardInput = $pathAndFilename === 'php://stdin';
$isFile = is_file($pathAndFilename);
Expand Down