[hackathon]: patched pgrx14 and updated anon#11978
Closed
Conversation
thesuhas
changed the title
8525 tests run: 7943 passed, 0 failed, 582 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
36a8503 at 2025-05-30T21:32:40.045Z :recycle: |
|
If this PR added a GUC in the Postgres fork or If you're an external contributor, a Neon employee will assist in |
thesuhas
force-pushed
the
thesuhas/patched-pgrx-14
branch
2 times, most recently
from
f5a4472 to
367c150
Compare
thesuhas
force-pushed
the
thesuhas/patched-pgrx-14
branch
from
367c150 to
fa7f5b6
Compare
myrrc
reviewed
Jun 2, 2025
| ARG PG_VERSION | ||
|
|
||
| RUN cargo install --locked --version 0.14.1 cargo-pgrx && \ | ||
| RUN cargo install --locked --git https://github.com/thesuhas/pgrx.git --branch expose_guc_assign_hook cargo-pgrx && \ |
Contributor
There was a problem hiding this comment.
If we want to maintain it, we should fork pgrx into neondatabase and use this URL instead of personal
Contributor
Author
There was a problem hiding this comment.
I have an open PR on PGRX: pgcentralfoundation/pgrx#2075
Once that has been released, we can just update it to the latest version of PGRX instead of creating a fork
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, PGRX does not have hooks for GUC. This hackathon project aims to add that, and patch the
anonextension to use these hooks to give users the ability to changeanonGUCs without needingcloud_adminorsuperuserpermissions.Summary of changes
Updated compute docker file to point to patched pgrx14 and patched
anonto make use of pgrx14 changes.Relevant PR: pgcentralfoundation/pgrx#2075
Relevant Issue: https://github.com/neondatabase/cloud/issues/20456