Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ability to enable stenciling #1830

Open
wants to merge 35 commits into
base: 1.21.x
Choose a base branch
from

Conversation

Technici4n
Copy link
Member

@Technici4n Technici4n commented Jan 9, 2025

  • Restore the ability to enable stenciling, by using an event that enables stencil for the main render targets.
  • Move mod construction, registry events, and config loading a bit earlier on the client.
  • Add a config option to choose between 32+8 and 24+8 stencil formats. We default to 32+8 because that is what was done in 1.21.1, but it is now possible to experiment with 24+8. It is still not clear what the performance benefits of 24+8 are, and whether this causes visual artifacts or not.
  • Add a basic test mod to validate that stencil can be enabled and used.

This PR is derived from #1715 with a lot of additional change since. Also brought further simplifications from FiniteReality#1.

@neoforged-automation neoforged-automation bot added the 1.21.4 Targeted at Minecraft 1.21.4 label Jan 9, 2025
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jan 9, 2025

  • Publish PR to GitHub Packages

Last commit published: e8f3e144f2701e62c1469de68b9c40a78f9bfac3.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1830' // https://github.com/neoforged/NeoForge/pull/1830
        url 'https://prmaven.neoforged.net/NeoForge/pr1830'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1830.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1830
cd NeoForge-pr1830
curl -L https://prmaven.neoforged.net/NeoForge/pr1830/net/neoforged/neoforge/21.4.95-beta-pr-1830-feature-depth-stenciling/mdk-pr1830.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Technici4n Technici4n changed the title Create a ConfigureMainRenderTargetEvent for enabling stenciling, simplified(?) Restore ability to enable stenciling Jan 15, 2025
@Technici4n Technici4n marked this pull request as ready for review January 15, 2025 23:28
@Technici4n Technici4n requested a review from shartte January 15, 2025 23:32
@Technici4n Technici4n requested a review from XFactHD January 15, 2025 23:54
…ble by pass shaders. Allowed me to simplify the event structure a lot.
Copy link
Contributor

@shartte shartte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok yeah I think this is nice.
We can add to PostChain if we discover issues with it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants