Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21.4] Remove getters and setters from Level.java.patch #1809

Open
wants to merge 1 commit into
base: 1.21.x
Choose a base branch
from
Open

[1.21.4] Remove getters and setters from Level.java.patch #1809

wants to merge 1 commit into from
+41 −73

Conversation

IThundxr
Copy link
Contributor

@IThundxr IThundxr commented Dec 31, 2024 •
edited
Loading

  • These getters and setters are not needed, and just make extending Level in a multiloader mod annoying.

@neoforged-automation neoforged-automation bot added the 1.21.4 Targeted at Minecraft 1.21.4 label Dec 31, 2024
@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@IThundxr IThundxr force-pushed the pr/remove-getters-and-setters branch from c65cc7d to 8013de0 Compare December 31, 2024 00:33
@neoforged-compatibility-checks
Copy link

neoforged-compatibility-checks bot commented Dec 31, 2024 •
edited
Loading

@IThundxr, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: 005f7e7df98688673c1f38b5c6f52974dd6db23e.

neoforge (:neoforge)

  • net/minecraft/world/level/Level
    • setDayTimePerTick(F)V: ❗ API method was removed
    • setDayTimeFraction(F)V: ⚠ API method was removed
    • advanceDaytime()J: ⚠ API method was removed
    • getDayTimeFraction()F: ⚠ API method was removed
    • getDayTimePerTick()F: ❗ API method was removed
  • net/minecraft/client/multiplayer/ClientLevel
    • setDayTimePerTick(F)V: ⚠ API method was removed
    • setDayTimeFraction(F)V: ⚠ API method was removed
    • getDayTimeFraction()F: ⚠ API method was removed
    • getDayTimePerTick()F: ❗ API method was removed

@IThundxr IThundxr force-pushed the pr/remove-getters-and-setters branch from add4bfb to eeb3773 Compare December 31, 2024 03:12
@IThundxr
Remove getters and setters from Level.java.patch
005f7e7 
- These getters and setters are not needed, and just make extending Level in a multiloader mod annoying.
@IThundxr IThundxr force-pushed the pr/remove-getters-and-setters branch from eeb3773 to 005f7e7 Compare December 31, 2024 03:16
@IThundxr IThundxr changed the title Remove getters and setters from Level.java.patch [1.21.4] Remove getters and setters from Level.java.patch Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.21.4 Targeted at Minecraft 1.21.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IThundxr