Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RenderSystem.activeTexture calls in ParticleEngine #1791

Conversation

sciwhiz12
Copy link
Member

This PR removes two calls to RenderSystem.activeTexture in ParticleEngine, which were originally introduced in MinecraftForge/MinecraftForge@fc3fa13 and reintroduced by MinecraftForge/MinecraftForge#8291 to fix a bug where particles sometimes rendered fullbright. The bug those lines originally fixed does not reappear when these calls are removed (as checked using the test from MinecraftForge/MinecraftForge#8221).

The bug this originally fixed does not reappear when these calls are
removed.
@sciwhiz12 sciwhiz12 added rendering Related to rendering cleanup Change that isn't an enhancement or a bug fix 1.21.4 Targeted at Minecraft 1.21.4 labels Dec 23, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Dec 23, 2024

  • Publish PR to GitHub Packages

Last commit published: 649515df5764a6734f1caa6a70ae8a282522d9ef.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1791' // https://github.com/neoforged/NeoForge/pull/1791
        url 'https://prmaven.neoforged.net/NeoForge/pr1791'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1791.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1791
cd NeoForge-pr1791
curl -L https://prmaven.neoforged.net/NeoForge/pr1791/net/neoforged/neoforge/21.4.40-beta-pr-1791-cleanup-1.21.4-particleengine-activetexture-porting-todo/mdk-pr1791.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@XFactHD XFactHD merged commit 2a0abf9 into neoforged:1.21.x Dec 27, 2024
7 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.4.44-beta.

@sciwhiz12 sciwhiz12 deleted the cleanup/1.21.4/particleengine-activetexture-porting-todo branch December 27, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 cleanup Change that isn't an enhancement or a bug fix rendering Related to rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants