Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Builder Method on Expressions + Update Proc Macro #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MinisculeGirraffe
Copy link

@MinisculeGirraffe MinisculeGirraffe commented Jan 10, 2024

Fixes #19.

Adds a method to handle adding a new expression while keeping the variables in-sync with the other methods

I also threw #12 in here as well.

I can break them up into separate PR's if you'd like.

Fact check me on the proc macro pls. This is like my second time writing one.

I tested everything locally and it seemed to work just fine. It worked both with a manually defined struct, and with one generated by struct-patch.

@MinisculeGirraffe MinisculeGirraffe changed the title Add Builder Method on Expressions Add Builder Method on Expressions + Update Proc Macro Jan 10, 2024
@neoeinstein
Copy link
Owner

Thanks for this. I'll be a bit slow on review due to other commitments, but should be able to get an initial review in the next couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute Names/Values are unexpected when building an update expression.
2 participants