Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

methods to clear cached classes after reload! is called #855

Merged
merged 2 commits into from
Jul 3, 2015

Conversation

subvertallchris
Copy link
Contributor

This appears to correct the root cause of #717 and possibly neo4jrb/devise-activegraph#16. It uses the before_remove_const method fired by ActiveSupport's reload! to wipe cached references to classes. It's possible others are still lurking but this will be a start.

subvertallchris added a commit that referenced this pull request Jul 3, 2015
methods to clear cached classes after `reload!` is called
@subvertallchris subvertallchris merged commit 05abc10 into master Jul 3, 2015
@subvertallchris subvertallchris deleted the constantize_problem branch July 8, 2015 19:06
@jacobwgillespie
Copy link
Contributor

Any news on when this PR might get released on Rubygems? Right now, using reload! in the console isn't working with the current version (5.0.14) and it looks like it's due to this not yet being released.

@cheerfulstoic
Copy link
Contributor

We definitely want to release a 5.1 soon. I've been producing some screencasts for the gems and the latest screencasts require some features in master, so those will need to be made publicly accessible.

@cheerfulstoic
Copy link
Contributor

To give a clearer answer: I expect we'll at least do an RC that'll be in the next week or two, one way or another.

@jacobwgillespie
Copy link
Contributor

Ah, gotcha, so this is going out as a point release and not a patch. Thank you for the work, I'll watch for the RC!

@cheerfulstoic
Copy link
Contributor

Ah, right. I'm not sure if @subvertallchris planned to do a patch (I know he's been busy with work lately), but obviously it will go out with a point release ;) Thanks for the patience

@subvertallchris
Copy link
Contributor Author

I think a patch release would be a good idea. A few people are locked to the specific commit that fixed it because they need what it provides, I think it would help them out. I'll take care of it when I have a few minutes today and will post here when it's done.

@jacobwgillespie
Copy link
Contributor

👍 Thank you!

@subvertallchris
Copy link
Contributor Author

Just released 5.0.15 with this. Let us know if you have any trouble.

@cheerfulstoic
Copy link
Contributor

@subvertallchris: CHANGELOG? ;)

@jacobwgillespie
Copy link
Contributor

It works great - thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants