use labels instead of is_a? to determine whether nodes are of appropriate type #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subvertallchris
force-pushed
the
association_class
branch
from
3ed32c7
to
5e3deb9
Compare
subvertallchris
added a commit
that referenced
this pull request
Jun 19, 2015
use labels instead of is_a? to determine whether nodes are of appropriate type
|
Oh, interesting, that probably makes sense. If I had to guess, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #717.
Rails
reload!method was bumping heads with the@modelinstance variable in QueryProxy. I can't totally pin down why, will need to look at it more another time. In the meantime, this skips around the problem by just using labels to determine whether nodes are of the appropriate type.No new tests, this is too specific to Rails and it doesn't add anything new, it ends up in the same place using existing methods.