Remove network call to exist? via to_key #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Killer, thank you! I'll merge as soon as Travis gives us the all-clear. |
| @@ -47,4 +47,27 @@ def id | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| describe '#to_key' do | |||
There was a problem hiding this comment.
Just fixed a missing "#" here so it'll probably take a second run through Travis. Sorry! :)
|
Sweet. Cheers! Really looking forward to getting stuck into Neo4J :) |
subvertallchris
added a commit
that referenced
this pull request
Jun 8, 2015
Remove network call to exist? via to_key
|
Feel free to say hello in our Gitter room anytime! @cheerfulstoic and I are almost always there during the day if you need anything or want to chat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #826 where every call to to_key was resulting in an extra network call.
cc @subvertallchris