Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generator cleanup with tests #1717

Merged
merged 47 commits into from
Jan 25, 2024
Merged

Generator cleanup with tests #1717

merged 47 commits into from
Jan 25, 2024

Conversation

mrhardikjoshi
Copy link
Member

This PR introduces tests on top of changes of #1716

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f86d54c) 93.12% compared to head (e496b98) 93.08%.

❗ Current head e496b98 differs from pull request most recent head 2d2f968. Consider uploading reports for the commit 2d2f968 to get more accurate results

Files Patch % Lines
lib/active_graph/railtie.rb 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##               11    #1717      +/-   ##
==========================================
- Coverage   93.12%   93.08%   -0.04%     
==========================================
  Files         128      128              
  Lines        5700     5700              
==========================================
- Hits         5308     5306       -2     
- Misses        392      394       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrhardikjoshi mrhardikjoshi changed the title Generator clenup with tests Generator cleanup with tests Jan 12, 2024
@mrhardikjoshi mrhardikjoshi mentioned this pull request Jan 12, 2024
Closed
mrhardikjoshi
mrhardikjoshi commented Jan 15, 2024
View reviewed changes
e2e_tests/setup.sh Outdated Show resolved Hide resolved
mrhardikjoshi
mrhardikjoshi commented Jan 15, 2024
View reviewed changes
e2e_tests/setup.sh Outdated Show resolved Hide resolved
@mrhardikjoshi
Copy link
Member Author

update readme file to include command/steps to run e2e tests

klobuczek
klobuczek previously approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@klobuczek klobuczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

docs/activegraph.rb Outdated Show resolved Hide resolved
@mrhardikjoshi
Copy link
Member Author

mrhardikjoshi commented Jan 25, 2024 •
edited
Loading

To Do Notes:

  1. add tests for down migration command
  2. add tests for running default rails tests in minitest
  3. cleanup and merge both github workflows

@klobuczek klobuczek merged commit 14376c2 into 11 Jan 25, 2024
30 of 31 checks passed
@klobuczek klobuczek deleted the generator_clenup_with_tests branch January 25, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klobuczek klobuczek klobuczek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrhardikjoshi @codecov-commenter @klobuczek