Add multi-database support to HTTP driver #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tested with Liquigraph. Works like a charm. |
fbiville
commented
May 6, 2020
| @@ -377,6 +386,10 @@ public Integer getOpenTransactionId() { | |||
| return getTransactionId(this.currentTransactionUrl); | |||
| } | |||
|
|
|||
| private String transactionPath(String databaseName) { | |||
| return String.format(DB_DATA_TRANSACTION_TEMPLATE, databaseName); | |||
There was a problem hiding this comment.
it appears there is no need for escaping, as database names can only be made of: "simple ascii characters, numbers, dots and dashes" and these characters are not URI special characters.
|
Would it be possible to get a release going once this is merged? Molte grazie! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227