Skip to content

Update console formatter to include exception in the formatting #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Update console formatter to include exception in the formatting #952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions driver/src/main/java/org/neo4j/driver/internal/logging/ConsoleLogging.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
*/
package org.neo4j.driver.internal.logging;

import java.io.PrintWriter;
import java.io.StringWriter;
import java.time.LocalDateTime;
import java.util.Objects;
import java.util.logging.ConsoleHandler;
Expand Down Expand Up @@ -70,14 +72,14 @@ public ConsoleLogger( String name, Level level )
}

handler = new ConsoleHandler();
handler.setFormatter( new ShortFormatter() );
handler.setFormatter( new ConsoleFormatter() );
handler.setLevel( level );
logger.addHandler( handler );
logger.setLevel( level );
}
}

private static class ShortFormatter extends Formatter
private static class ConsoleFormatter extends Formatter
{
@Override
public String format( LogRecord record )
Expand All @@ -86,7 +88,23 @@ public String format( LogRecord record )
record.getLevel() + " " +
record.getLoggerName() + " - " +
formatMessage( record ) +
formatThrowable( record.getThrown() ) +
"\n";
}

private String formatThrowable( Throwable throwable )
{
String throwableString = "";
if ( throwable != null )
{
StringWriter sw = new StringWriter();
PrintWriter pw = new PrintWriter( sw );
pw.println();
throwable.printStackTrace( pw );
pw.close();
throwableString = sw.toString();
}
return throwableString;
}
}
}