Daemonize event loop threads. #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This instructs the `EventLoopGroupFactory` to daemonize newly created event loop group threads as per Netty's `DefaultThreadFactory`. This allows applications to shutdown when the last user thread ends, without explicitly calling `close` to the Neo4j driver instance, which is in line with other database drivers such as Postgres JDBC or MySQL JDBC. In addition, this might become relevant with Netty 5 at some point in the future, too. See: netty/netty#2832.
gjmwoods
approved these changes
Jun 14, 2021
michael-simons
added a commit
to michael-simons/neo4j-java-driver
that referenced
this pull request
Jun 14, 2021
This instructs the `EventLoopGroupFactory` to daemonize newly created event loop group threads as per Netty's `DefaultThreadFactory`. This allows applications to shutdown when the last user thread ends, without explicitly calling `close` to the Neo4j driver instance, which is in line with other database drivers such as Postgres JDBC or MySQL JDBC. In addition, this might become relevant with Netty 5 at some point in the future, too. See: netty/netty#2832.
michael-simons
added a commit
to michael-simons/neo4j-java-driver
that referenced
this pull request
Jun 14, 2021
This instructs the `EventLoopGroupFactory` to daemonize newly created event loop group threads as per Netty's `DefaultThreadFactory`. This allows applications to shutdown when the last user thread ends, without explicitly calling `close` to the Neo4j driver instance, which is in line with other database drivers such as Postgres JDBC or MySQL JDBC. In addition, this might become relevant with Netty 5 at some point in the future, too. See: netty/netty#2832.
michael-simons
added a commit
to michael-simons/neo4j-java-driver
that referenced
this pull request
Jun 14, 2021
This instructs the `EventLoopGroupFactory` to daemonize newly created event loop group threads as per Netty's `DefaultThreadFactory`. This allows applications to shutdown when the last user thread ends, without explicitly calling `close` to the Neo4j driver instance, which is in line with other database drivers such as Postgres JDBC or MySQL JDBC. In addition, this might become relevant with Netty 5 at some point in the future, too. See: netty/netty#2832.
michael-simons
added a commit
to michael-simons/neo4j-java-driver
that referenced
this pull request
Jun 14, 2021
This instructs the `EventLoopGroupFactory` to daemonize newly created event loop group threads as per Netty's `DefaultThreadFactory`. This allows applications to shutdown when the last user thread ends, without explicitly calling `close` to the Neo4j driver instance, which is in line with other database drivers such as Postgres JDBC or MySQL JDBC. In addition, this might become relevant with Netty 5 at some point in the future, too. See: netty/netty#2832.
fbiville
added a commit
to neo4j/neo4j-jdbc
that referenced
this pull request
Sep 13, 2021
The recent Java driver configures Netty so that it spawns deamon threads for its event loops and therefore does not block application when they shut down. This is especially useful for CLI applications using the JDBC driver. See neo4j/neo4j-java-driver#918 for more context.
fbiville
added a commit
to neo4j/neo4j-jdbc
that referenced
this pull request
Sep 13, 2021
The recent Java driver configures Netty so that it spawns deamon threads for its event loops and therefore does not block application when they shut down. This is especially useful for CLI applications using the JDBC driver. See neo4j/neo4j-java-driver#918 for more context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This instructs the
EventLoopGroupFactoryto daemonize newly createdevent loop group threads as per Netty's
DefaultThreadFactory. Thisallows applications to shutdown when the last user thread ends, without
explicitly calling
closeto the Neo4j driver instance, which is inline with other database drivers such as Postgres JDBC or MySQL JDBC.
In addition, this might become relevant with Netty 5 at some point in
the future, too. See: netty/netty#2832.