-
Notifications
You must be signed in to change notification settings - Fork 4
[WIP] MCP HTTP - Auth0 flow #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
baseURL := scheme + "://" + r.Host | ||
|
||
metadata := map[string]interface{}{ | ||
"issuer": "https://" + s.config.Auth0Domain + "/", | ||
"authorization_endpoint": baseURL + "/authorize", | ||
"token_endpoint": baseURL + "/token", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these not also be URLs on the auth server, not the client?
baseURL := scheme + "://" + r.Host | |
metadata := map[string]interface{}{ | |
"issuer": "https://" + s.config.Auth0Domain + "/", | |
"authorization_endpoint": baseURL + "/authorize", | |
"token_endpoint": baseURL + "/token", | |
metadata := map[string]interface{}{ | |
"issuer": "https://" + s.config.Auth0Domain + "/", | |
"authorization_endpoint": s.config.Auth0Domain + "/authorize", | |
"token_endpoint": s.config.Auth0Domain + "/token", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, and I think this currently works as you said because our OAuth proxy is already redirecting these requests (through baseURL
) to s.config.Auth0Domain
, which seems like an unnecessary step. Therefore, we should be able to update these redirect URLs and eliminate our own OAuth proxy. I'll look into that.
closing in favor of #61 to avoid confusion |
You'd need to manually add the MCP and the localhost URL in VSCode. The config I ended up having is below, not sure if we need all of it yet;
where
http://127.0.0.1:50115
is the VSCode OAuth redirect URL, which might be different for you.And some Auth0 config is required;