Skip to content

Conversation

keremgocen
Copy link
Contributor

@keremgocen keremgocen commented Sep 30, 2025

Introduce error handling in the Neo4j service, implement a session interface for better testability, and add realistic test scenarios. Refactor code to improve clarity and maintainability.

  • expands the interfaces we are using from Neo4j driver for testability, they are now moved into adapters.go to keep it tidy
  • more unit test coverage in service.go now but ideally we'd like to introduce integration tests since not everything in the driver is exported so it's hard to test in unit tests (you need to do a lot of mocking and wrapping)

trello

@keremgocen keremgocen marked this pull request as ready for review September 30, 2025 10:35
@keremgocen keremgocen requested a review from mjfwebb October 9, 2025 09:51
Copy link
Contributor

@MacondoExpress MacondoExpress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely ! 💯

@keremgocen keremgocen merged commit d12b282 into main Oct 16, 2025
7 checks passed
@keremgocen keremgocen deleted the keremgocen/add-test-coverage-for-database-service branch October 16, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants