Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notion of v1 and v2 discovery services #1994

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jackwaudby
Copy link
Contributor

Removes all mention of v1 and v2 discovery services. We update all configurations and setup guides to reflect there is now one discovery service with 2 settings:

  • dbms.cluster.endpoints
  • dbms.cluster.discovery.resolver_type

@jackwaudby jackwaudby force-pushed the 2024-12-one-discovery-service branch from 990dbbc to 01eda91 Compare December 10, 2024 13:48
@@ -9,25 +9,6 @@ This information is necessary to connect to the servers, run the discovery proto

Neo4j provides several mechanisms for cluster members to discover each other and form a cluster based on the configuration and the environment in which the cluster is running, as well as the version of Neo4j being used.

Copy link
Contributor

@NataliaIvakina NataliaIvakina Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[IMPORTANT]
====
In Neo4j 5.23, a new discovery service was introduced.
It is very crucially important to switch to the the new version before you start using Neo4j 2025.01.
See link:https://neo4j.com/docs/operations-manual/5/clustering/setup/discovery/[the guide for the Neo4j 5.x series] for more information.
====

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still be inclined to remove the notion of v2 here

@@ -9,25 +9,6 @@ This information is necessary to connect to the servers, run the discovery proto

Neo4j provides several mechanisms for cluster members to discover each other and form a cluster based on the configuration and the environment in which the cluster is running, as well as the version of Neo4j being used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still be inclined to remove the notion of v2 here

@@ -9,25 +9,6 @@ This information is necessary to connect to the servers, run the discovery proto

Neo4j provides several mechanisms for cluster members to discover each other and form a cluster based on the configuration and the environment in which the cluster is running, as well as the version of Neo4j being used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In Neo4j 5.23 a new discovery service was introduced.
It is crucial to switch to this new version before you start using Neo4j 2025.01.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants