Add metrics for Raft Snapshots. Attempt/success/fail #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9a97a8f.
|
This PR includes documentation updates Updated pages: |
|
The PR has now been merged |
Super! Thank you for the update. But we'll wait to merge this PR into docs until the 5.26 release is published. |
There was a problem hiding this comment.
@RagnarW hey! I did a little research. So, here are my editorial suggestions for the metrics' descriptions.
Maybe it's worth adding more details on their purpose or role.
| @@ -578,6 +578,9 @@ The deprecated Raft core metrics are replaced accordingly by the Raft metrics in | |||
| |<prefix>.cluster.raft.replication_maybe|Raft Replication maybe count. (counter) | |||
| |<prefix>.cluster.raft.replication_success|The total number of Raft replication requests that have succeeded. (counter) | |||
| |<prefix>.cluster.raft.last_leader_message|The time elapsed since the last message from a leader in milliseconds. Should reset periodically. (gauge) | |||
| |<prefix>.cluster.raft.snapshot_attempt|Downloading of Raft snapshot attempts triggered. (counter) | |||
There was a problem hiding this comment.
Suggested change
| |<prefix>.cluster.raft.snapshot_attempt|Downloading of Raft snapshot attempts triggered. (counter) | |
| |<prefix>.cluster.raft.snapshot_attempt|Total number of attempts to download Raft snapshots triggered. (counter) |
| @@ -578,6 +578,9 @@ The deprecated Raft core metrics are replaced accordingly by the Raft metrics in | |||
| |<prefix>.cluster.raft.replication_maybe|Raft Replication maybe count. (counter) | |||
| |<prefix>.cluster.raft.replication_success|The total number of Raft replication requests that have succeeded. (counter) | |||
| |<prefix>.cluster.raft.last_leader_message|The time elapsed since the last message from a leader in milliseconds. Should reset periodically. (gauge) | |||
| |<prefix>.cluster.raft.snapshot_attempt|Downloading of Raft snapshot attempts triggered. (counter) | |||
| |<prefix>.cluster.raft.snapshot_success|Downloading of Raft snapshot successful downloads. (counter) | |||
There was a problem hiding this comment.
Suggested change
| |<prefix>.cluster.raft.snapshot_success|Downloading of Raft snapshot successful downloads. (counter) | |
| |<prefix>.cluster.raft.snapshot_success|Total number of successfully downloaded Raft snapshots. (counter) |
| @@ -578,6 +578,9 @@ The deprecated Raft core metrics are replaced accordingly by the Raft metrics in | |||
| |<prefix>.cluster.raft.replication_maybe|Raft Replication maybe count. (counter) | |||
| |<prefix>.cluster.raft.replication_success|The total number of Raft replication requests that have succeeded. (counter) | |||
| |<prefix>.cluster.raft.last_leader_message|The time elapsed since the last message from a leader in milliseconds. Should reset periodically. (gauge) | |||
| |<prefix>.cluster.raft.snapshot_attempt|Downloading of Raft snapshot attempts triggered. (counter) | |||
| |<prefix>.cluster.raft.snapshot_success|Downloading of Raft snapshot successful downloads. (counter) | |||
| |<prefix>.cluster.raft.snapshot_fail|Downloading of Raft snapshot failed downloads. (counter) | |||
There was a problem hiding this comment.
Suggested change
| |<prefix>.cluster.raft.snapshot_fail|Downloading of Raft snapshot failed downloads. (counter) | |
| |<prefix>.cluster.raft.snapshot_fail|Total number of failed Raft snapshot download attempts. (counter) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding metrics for Raft Snapshot download. See https://github.com/neo-technology/neo4j/pull/28148