-
Notifications
You must be signed in to change notification settings - Fork 64
Divide managing index page #1432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
AlexicaWright
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of breaking this up, it's much more readable this way. My only comment has nothing to do with the breaking up of the structure but with the admonition syntax.
Will any redirects/page-aliases be needed as a result of this re-org?
modules/ROOT/pages/indexes/search-performance-indexes/create-indexes.adoc
Show resolved
Hide resolved
…ndexes.adoc Co-authored-by: Jessica Wright <[email protected]>
Hunterness
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did find some odd things on the setup lists (and then some other comments as well)
modules/ROOT/pages/indexes/search-performance-indexes/index.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/search-performance-indexes/create-indexes.adoc
Show resolved
Hide resolved
modules/ROOT/pages/indexes/search-performance-indexes/drop-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/search-performance-indexes/create-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/search-performance-indexes/drop-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/search-performance-indexes/drop-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/search-performance-indexes/drop-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/search-performance-indexes/drop-indexes.adoc
Outdated
Show resolved
Hide resolved
|
This PR includes documentation updates New pages: Updated pages: |
Hunterness
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small thing I noticed that doesn't really have to do with the dividing of the pages 🤷
| | `ZONED DATETIME` | ||
|
|
||
| | `options` | ||
| | Information retrieved from the `OPTIONS` map about the provider and configuration settings for an index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Cypher 5 we return both provider and configuration settings but in Cypher 25 we only return the configuration settings in the options column. So this sentence should maybe be updated to reflect that 🤔 This would also be true for show constraints as well and not just show index (as I assume it has a similar sentence around it's options column).
Not really related to your PR I just noticed this sentence now.
Splitting the managing-indexes page, similar to what #1406 does for constraints
Once both are in dev, the pages should also be moved to the schema nav entry.
Most of the files touched here are updated links.
Relevant for Review are the commented out listings for indexes in list-indexes.adoc and drop-indexes.adoc - those were collected from create-indexes.adoc.