Skip to content

Conversation

@rsill-neo4j
Copy link
Contributor

Splitting the managing-indexes page, similar to what #1406 does for constraints

Once both are in dev, the pages should also be moved to the schema nav entry.

Most of the files touched here are updated links.
Relevant for Review are the commented out listings for indexes in list-indexes.adoc and drop-indexes.adoc - those were collected from create-indexes.adoc.

Copy link
Contributor

@AlexicaWright AlexicaWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of breaking this up, it's much more readable this way. My only comment has nothing to do with the breaking up of the structure but with the admonition syntax.
Will any redirects/page-aliases be needed as a result of this re-org?

Copy link
Collaborator

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did find some odd things on the setup lists (and then some other comments as well)

Copy link
Collaborator

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing I noticed that doesn't really have to do with the dividing of the pages 🤷

| `ZONED DATETIME`

| `options`
| Information retrieved from the `OPTIONS` map about the provider and configuration settings for an index.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Cypher 5 we return both provider and configuration settings but in Cypher 25 we only return the configuration settings in the options column. So this sentence should maybe be updated to reflect that 🤔 This would also be true for show constraints as well and not just show index (as I assume it has a similar sentence around it's options column).

Not really related to your PR I just noticed this sentence now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants