Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed menu placement for node property selector in form modal #726

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

nielsdejong
Copy link
Collaborator

This is a fix for #700

Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 158 lines in your changes are missing coverage. Please review.

Comparison is base (fef6f9a) 38.71% compared to head (b9ab834) 38.69%.
Report is 3 commits behind head on develop.

Files Patch % Lines
src/dashboard/DashboardThunks.ts 3.75% 77 Missing ⚠️
src/application/logging/LoggingThunk.ts 2.94% 33 Missing ⚠️
src/dashboard/sidebar/DashboardSidebar.tsx 13.33% 12 Missing and 1 partial ⚠️
src/application/ApplicationReducer.ts 40.00% 12 Missing ⚠️
src/modal/ConnectionModal.tsx 46.15% 6 Missing and 1 partial ⚠️
src/application/ApplicationThunks.ts 72.72% 3 Missing ⚠️
src/application/logging/LoggingReducer.ts 85.71% 3 Missing ⚠️
src/application/ApplicationSelectors.ts 66.66% 2 Missing ⚠️
src/dashboard/Dashboard.tsx 50.00% 1 Missing and 1 partial ⚠️
src/dashboard/header/DashboardHeader.tsx 33.33% 1 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #726      +/-   ##
===========================================
- Coverage    38.71%   38.69%   -0.03%     
===========================================
  Files          203      207       +4     
  Lines         8462     8630     +168     
  Branches      2504     2567      +63     
===========================================
+ Hits          3276     3339      +63     
- Misses        5127     5231     +104     
- Partials        59       60       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AleSim94 AleSim94 merged commit 58b188c into develop Dec 6, 2023
3 of 5 checks passed
@nielsdejong nielsdejong mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants