Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font-color not changed in graph contextual popups when in dark mode #621 #699

Conversation

JonanOribe
Copy link
Contributor

Hotfix over the light/dark mode on pop ups mentioned on issue #621

Before:

image

After:

image

image

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 1980 lines in your changes are missing coverage. Please review.

Comparison is base (f151d32) 46.28% compared to head (9486969) 38.73%.
Report is 29 commits behind head on develop.

Files Patch % Lines
...ons/advancedcharts/chart/gantt/frappe/lib/index.ts 0.43% 453 Missing ⚠️
...sions/advancedcharts/chart/gantt/frappe/lib/bar.ts 0.00% 194 Missing ⚠️
src/dashboard/sidebar/DashboardSidebar.tsx 13.11% 158 Missing and 1 partial ⚠️
...dvancedcharts/chart/gantt/frappe/lib/date_utils.js 6.08% 92 Missing and 16 partials ⚠️
...tensions/advancedcharts/chart/gantt/GanttChart.tsx 1.13% 87 Missing ⚠️
src/extensions/forms/chart/NeoForm.tsx 1.44% 68 Missing ⚠️
.../text2cypher/component/OverrideCardQueryEditor.tsx 4.22% 68 Missing ⚠️
src/dashboard/DashboardThunks.ts 12.69% 55 Missing ⚠️
...advancedcharts/chart/gantt/frappe/lib/svg_utils.ts 9.83% 55 Missing ⚠️
src/extensions/text2cypher/clients/ModelClient.ts 0.00% 54 Missing ⚠️
... and 69 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #699      +/-   ##
===========================================
- Coverage    46.28%   38.73%   -7.56%     
===========================================
  Files          166      203      +37     
  Lines         6594     8461    +1867     
  Branches      2043     2503     +460     
===========================================
+ Hits          3052     3277     +225     
- Misses        3501     5125    +1624     
- Partials        41       59      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alfredorubin96 alfredorubin96 merged commit 4220f54 into neo4j-labs:develop Nov 27, 2023
3 of 5 checks passed
@BennuFire BennuFire self-assigned this Nov 27, 2023
@BennuFire
Copy link
Contributor

@alfredorubin96 Two things:

  1. Default text color should never be a constant color (it should also be a Needle Token)
  2. It should be checked if this behavior can be done once for all the portals (every modal has this problem)

@nielsdejong nielsdejong mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants