Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote Sidebar Import + Fixes #571

Merged
merged 22 commits into from
Aug 21, 2023
Merged

Remote Sidebar Import + Fixes #571

merged 22 commits into from
Aug 21, 2023

Conversation

BennuFire
Copy link
Contributor

No description provided.

nielsdejong
nielsdejong approved these changes Aug 21, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/card/settings/CardSettingsContent.tsx Show resolved Hide resolved
src/dashboard/header/DashboardHeaderPageTitle.tsx Show resolved Hide resolved
webpack.config.js Show resolved Hide resolved
nielsdejong
nielsdejong requested changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@nielsdejong nielsdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 5 Code Smells

No Coverage information No Coverage information
1.8% 1.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@BennuFire BennuFire merged commit 69dbf15 into develop Aug 21, 2023
1 of 3 checks passed
@nielsdejong nielsdejong mentioned this pull request Aug 21, 2023
Merged
@BennuFire BennuFire mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdejong nielsdejong nielsdejong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BennuFire @nielsdejong