-
Notifications
You must be signed in to change notification settings - Fork 12
Complete Result.peek tests #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2022
b115131 to
a142333
Compare
Signed-off-by: Florent Biville <[email protected]>
a142333 to
a13d6f6
Compare
6b12a56 to
1130869
Compare
bigmontz
approved these changes
Jan 24, 2022
Contributor
bigmontz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏑
injectives
pushed a commit
to injectives/testkit
that referenced
this pull request
Jan 27, 2022
* Add Java error check to Result.peek tests * Adjust backend to not expect Go to re-raise errors on Session.Close Signed-off-by: Florent Biville <[email protected]> * Fix tx handling in test * Fix driver specific tx.close() and tx.rollback() calls * Use tx.rollback() where tx.close() is not needed * Replaced another tx.close() with tx.rollback()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.