Don't add log4j vulnerability fix every time. #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuslundahl
commented
Mar 8, 2022
Comment on lines
+309
to
+311
| const log4jVulnFix = neo4jConfig.config.find( | ||
| (item) => item[0] === 'dbms.jvm.additional' && item[1] === '-Dlog4j2.formatMsgNoLookups=true', | ||
| ); |
There was a problem hiding this comment.
neo4jConfig.get('dbms.jvm.additional=-Dlog4j2.formatMsgNoLookups') isn't working when trying to fetch if the setting has been added.
There was a problem hiding this comment.
I realized only now, but wouldn't the key be only dbms.jvm.additional? So you'd check with
neo4jConfig.get('dbms.jvm.additional') === '-Dlog4j2.formatMsgNoLookups'
and set as
neo4jConfig.set('dbms.jvm.additional', '-Dlog4j2.formatMsgNoLookups')
There was a problem hiding this comment.
No, there are multiple entries that starts with dbms.jvm.additional in the conf file already. And using neo4jConfig.get('dbms.jvm.additional') will return the first one. In the default case we get -XX:+UseG1GC. So that won't do...
There was a problem hiding this comment.
and the actual setting is: dbms.jvm.additional=-Dlog4j2.formatMsgNoLookups=true.
nglgzz
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Prevent duplication of the log4j vulnerability fix setting. Apparently doing
neo4jConfig.get('dbms.jvm.additional=-Dlog4j2.formatMsgNoLookups')doesn't returntrue, I'm guessing the double equal signs in the setting (dbms.jvm.additional=-Dlog4j2.formatMsgNoLookups=true) screws up the fetching of it.What is the current behavior?
dbms.jvm.additional=-Dlog4j2.formatMsgNoLookups=trueis added as a new line in the config on each DBMS start.What is the new behavior?
dbms.jvm.additional=-Dlog4j2.formatMsgNoLookups=trueis only added once to the config.Does this PR introduce a breaking change?
Other information: