Allow URLs for Sample Project dumps and scripts #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuslundahl
changed the title
linuslundahl
force-pushed
the
feature/url-for-import-sample-projects
branch
from
a9c7279
to
f6fa0d6
Compare
linuslundahl
force-pushed
the
feature/url-for-import-sample-projects
branch
from
f6fa0d6
to
5f6d3b3
Compare
nglgzz
approved these changes
Feb 2, 2022
| @@ -130,7 +129,7 @@ export abstract class ProjectsAbstract<Env extends EnvironmentAbstract> { | |||
| /** | |||
| * Lists sample projects from github (https://github.com/neo4j-graph-examples) | |||
| */ | |||
| abstract listSampleProjects(fetch?: () => any | Got): Promise<List<ISampleProjectRest>>; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Allows for
dumpFileor ascriptFilein the sample project dbms description to point to a URL instead of a local file. The file will be downloaded before it is imported.Also removes
gotforlistSampleProjectsand usesrequestJsoninstead, which should work with the Desktop proxy.What is the current behavior?
Currently only local files can be defined.
What is the new behavior?
(if this is a feature change)
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Other information: