Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoist dependencies with Lerna and upgrade Nest.js #335

Merged
merged 5 commits into from
Oct 19, 2021

Conversation

nglgzz
Copy link
Contributor

@nglgzz nglgzz commented Sep 30, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Hoist dependencies with Lerna to ensure that the Nest.js packages are installed only once, and upgrade Nest.js, typescript, and some other related dependencies.

What is the current behavior?

  • Dependencies are installed multiple times across all packages.
  • We use Nest.js 7.
  • Each package generates its own package lock.

What is the new behavior?

  • Dependencies are hoisted at the root of the project.
  • We use Nest.js 8.
  • Only one package lock is now maintained at the root of the project, all other package locks have been removed.
  • There's a linting rule to ensure we don't import packages that aren't included in the package.json (More about that here)

Does this PR introduce a breaking change?

No

Other information:

As in the previous attempt to upgrade Nest.js, most of the changes in this PR are TypeScript, Eslint, and Prettier fixes.

emmaagh
emmaagh previously approved these changes Oct 4, 2021
Copy link
Contributor

@emmaagh emmaagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me! I tested linking the common package in desktop v1 & v2 and that all seemed to work as expected.

.nth(1)
.get(),
).toBe(true);
expect(List.from('bar').nth(0).get()).toBe('b');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This formatting is so much better lol

@emmaagh
Copy link
Contributor

emmaagh commented Oct 4, 2021

Just noticed there's a conflict in 1 file FYI

@nglgzz nglgzz merged commit 6769a2a into neo4j-devtools:master Oct 19, 2021
@nglgzz nglgzz deleted the lerna-hoist branch October 19, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants