Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoSchemaFile option to WebModule config #333

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

nglgzz
Copy link
Contributor

@nglgzz nglgzz commented Sep 15, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Add an option in the WebModule config for setting the autoSchemaFile value in the GraphQLModule.

What is the current behavior?

GraphQL schemas are always generated and stored in memory.

What is the new behavior?

The WebModule can now be configured to generate the schema locally if needed (eg. for verifying queries with eslint-plugin-graphql).

Does this PR introduce a breaking change?

No

Other information:

@nglgzz nglgzz requested a review from emmaagh September 15, 2021 08:45
Copy link
Contributor

@emmaagh emmaagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on local development on Desktop v2 on Windows.

@nglgzz nglgzz merged commit f72bbe2 into neo4j-devtools:master Sep 15, 2021
@nglgzz nglgzz deleted the web-config branch September 15, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants