dbms-plugins resolvers and tests added #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jk05
force-pushed
the
web-api-update_dbms-plugins
branch
5 times, most recently
from
f05d567
to
2404dc5
Compare
nglgzz
reviewed
Sep 16, 2021
| export class DbmsPluginSource extends DbmsPluginSourceBase {} | ||
|
|
||
| @ObjectType() | ||
| export class DbmsPluginInstalled extends DbmsPluginSource implements IDbmsPluginInstalled { |
There was a problem hiding this comment.
I understand they're pretty much the same, so it probably doesn't matter, but shouldn't this class extend DbmsPluginSourceBase?
There was a problem hiding this comment.
let me take a look, I cant recall why I did it this way
| } | ||
|
|
||
| @ArgsType() | ||
| export class InstallOrUninstallDbmsPluginArgs { |
There was a problem hiding this comment.
Since you only have the plugin name here and not all the args that are needed for installing/uninstalling plugins, PluginNameArgs might be a more accurate name instead?
jk05
force-pushed
the
web-api-update_dbms-plugins
branch
from
2404dc5
to
ffefa85
Compare
nglgzz
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Added resolvers and tests for the following
dbms-pluginoperations:add-sourceslist-sourcesremove-sourcesinstalllistuninstallWhat is the current behavior?
No resolvers or tests for and
dbms-pluginsoperationsWhat is the new behavior?
Can now list/add/remove dbms-plugins and sources.
Does this PR introduce a breaking change?
no
Other information: