Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign PowerShell script to start DBMSs #318

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

nglgzz
Copy link
Contributor

@nglgzz nglgzz commented Jul 23, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

The PowerShell script we use to start DBMSs is not signed, so in certain environments it fails to execute.

What is the new behavior?

The PowerShell script is now signed.

Does this PR introduce a breaking change?

No.

Other information:

If we do further changes to this script in the future we'll have to sign it again. For now I did it manually, but if we start making more changes in the future (which I doubt will be the case) it might be worth adding this step as part of the release pipeline.

To test that the signature is valid run the following command in PowerShell:

Get-AuthenticodeSignature .\packages\common\neo4j-start.ps1

@nglgzz nglgzz requested a review from emmaagh July 23, 2021 12:11
Copy link
Contributor

@emmaagh emmaagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖋️

@nglgzz nglgzz merged commit b519bed into neo4j-devtools:master Jul 23, 2021
@nglgzz nglgzz deleted the sign-ps1-script branch July 23, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants