Refactored OSMImporter. #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a couple of grammar syntax fixes to keep the README uniform. Also includes a brief phrase restructure for how you alert the user of the GeoServer version.
Minor doc updates
docs are TODO spatial.addPointLayer spatial.addLayer spatial.layer spatial.addNode spatial.addNodes spatial.addWKT spatial.addWKTs spatial.bbox spatial.closest spatial.distance spatial.updateFromWKT
* no plain numbers passed in anymore but either nodes or maps with short or long names * added distance column to spatial.distance result
isOneway(...) seems to be needed in references like e.g. Travis CI, so I re-added it as redelegation to getRoadDirection(...), as the implementation stayed the same (the new Javadoc links towards getDirection(...) too)
@craigtaverner was fine with sorting out the problems via issues (if they come up), so I removed the legacy method `isOneway(...)`. I did think about making it private, but I feel like it would be a change which is too difficult to sort out - the way it is now, a simple renaming would be fine, while making the method private would require ugly workarounds from the people who are actually using it by now. There may be none, but I don't want to risk it.
|
Oh no... did it apply all master branch commits to my 0.15-2.3 branch??? Why on Earth that??? |
|
And again, and again, and again... Sometimes Git just won't get it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #231. The method is still public because if people do use this method, making it private would result in ugly workarounds necessary at those spots, and I didn't want to risk that.
I wonder why all those other commits are in though. I'd bet something is messed up again...