Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

fixes #104 run-time detection of namespace without helm #107

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

moxious
Copy link
Contributor

@moxious moxious commented Sep 28, 2020

No description provided.

@moxious
Copy link
Contributor Author

moxious commented Sep 28, 2020

@eastlondoner pretty sure this is what you had in mind -- but please provide LGTM or thumbs up and I'll merge.

@eastlondoner
Copy link
Contributor

yes - should we do some testing?

@moxious
Copy link
Contributor Author

moxious commented Sep 28, 2020

@eastlondoner suggest something specific over and above "the cluster forms" and "all CI tests pass" which includes checking for services, data replication, etc. etc.

@eastlondoner
Copy link
Contributor

cluster forms is good enough for me

@moxious
Copy link
Contributor Author

moxious commented Sep 28, 2020

I guess one hinky bit about this is whether this special magic mounted namespace file on Kubernetes is ever different, i.e. with older versions of kubernetes, distros for other clouds, etc. etc.

Interestingly, in an unrelated issue a user providing feedback made some points about helm being used for deterministic deploys, and relative to these comments, getting the value dynamically at runtime might not be desirable. #101 (comment)

So perhaps a core question is how much commitment is made to helm, vs. how much we're ok with helm being used as a templating engine but not actively managing the release.

@eastlondoner
Copy link
Contributor

yes, I am not anxious to rush this in.

@moxious moxious merged commit 6b74e82 into master Jan 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants