Skip to content

Fix WhiteList#4434

Merged
shargon merged 2 commits intoneo-project:master-n3from
erikzhang:fix-whitelist
Jan 14, 2026
Merged

Fix WhiteList#4434
shargon merged 2 commits intoneo-project:master-n3from
erikzhang:fix-whitelist

Conversation

@erikzhang
Copy link
Member

No description provided.

@github-actions github-actions bot added the N3 label Jan 14, 2026
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need an extra change. If a context is created from a whitelisted one, it should be whitelisted too

@erikzhang
Copy link
Member Author

I think we need an extra change. If a context is created from a whitelisted one, it should be whitelisted too

Why?

@shargon
Copy link
Member

shargon commented Jan 14, 2026

I think we need an extra change. If a context is created from a whitelisted one, it should be whitelisted too

Why?

Imagine that you whitelist flamingo swap, but this swap call a different contract, not whitelisted. It should be whitelisted, isn't it?

@erikzhang
Copy link
Member Author

Imagine that you whitelist flamingo swap, but this swap call a different contract, not whitelisted. It should be whitelisted, isn't it?

This could potentially lead to attacks. For example, OnNEP17Payment might contain an infinite loop.

@superboyiii superboyiii mentioned this pull request Jan 14, 2026
Copy link
Member

@superboyiii superboyiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is passed.

@shargon shargon merged commit 309353a into neo-project:master-n3 Jan 14, 2026
7 checks passed
@erikzhang erikzhang mentioned this pull request Jan 14, 2026
18 tasks
@erikzhang erikzhang deleted the fix-whitelist branch January 14, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants