Skip to content

Add RoutingTable for DHT#4422

Merged
erikzhang merged 15 commits intoneo-project:masterfrom
erikzhang:RoutingTable
Feb 5, 2026
Merged

Add RoutingTable for DHT#4422
erikzhang merged 15 commits intoneo-project:masterfrom
erikzhang:RoutingTable

Conversation

@erikzhang
Copy link
Member

No description provided.

@github-actions github-actions bot added the N4 label Jan 9, 2026
Jim8y
Jim8y previously approved these changes Jan 28, 2026
Jim8y
Jim8y previously approved these changes Jan 28, 2026
@Jim8y Jim8y requested review from ajara87, shargon and vncoelho January 28, 2026 10:06
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need at least 1 weak to verify this PR with care

shargon
shargon previously approved these changes Feb 1, 2026
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that improve, LGTM but require more testing in future

ajara87
ajara87 previously approved these changes Feb 1, 2026
Co-authored-by: Shargon <shargon@gmail.com>
@erikzhang erikzhang dismissed stale reviews from ajara87, shargon, and Jim8y via 86c823d February 2, 2026 14:33
}
if (node.Version.NodeId == NodeId)
{
reason = DisconnectReason.Close;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same identity error?

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
When possible I will test master N4 node again.

@erikzhang erikzhang merged commit 587ec65 into neo-project:master Feb 5, 2026
14 checks passed
@erikzhang erikzhang deleted the RoutingTable branch February 5, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants