Skip to content

Add validation for BIP-0032 #4421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shargon merged 2 commits into from
Jan 9, 2026
Merged

Add validation for BIP-0032 #4421

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08617b7
Add validation like n3
ajara87 Jan 8, 2026
575d1c0
Merge branch 'master' into pk-validate
ajara87 Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Neo/Wallets/BIP32/ExtendedKey.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,15 @@ public ExtendedKey Derive(uint index)
static byte[] AddModN(ReadOnlySpan<byte> a, ReadOnlySpan<byte> b, BigInteger n)
{
BigInteger aInt = new(a, isUnsigned: true, isBigEndian: true);
// Check if parse256(IL) >= n (BIP32 requirement)
if (aInt >= n)
throw new InvalidOperationException("Derived child private key is invalid.");

BigInteger bInt = new(b, isUnsigned: true, isBigEndian: true);
BigInteger r = (aInt + bInt) % n;
if (r.IsZero)
throw new InvalidOperationException("Derived child private key is invalid.");

byte[] result = new byte[32];
Span<byte> tmp = stackalloc byte[32];
r.TryWriteBytes(tmp, out int bytesWritten, isUnsigned: true, isBigEndian: true);
Expand Down