Skip to content

[bug] Change crypto package #3977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

[bug] Change crypto package #3977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Neo/Neo.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<ItemGroup>
<PackageReference Include="Akka" Version="1.5.36" />
<PackageReference Include="BouncyCastle.NetCore" Version="2.2.1" />
<PackageReference Include="BouncyCastle.Cryptography" Version="2.6.1" />
<PackageReference Include="K4os.Compression.LZ4" Version="1.3.8" />
<PackageReference Include="Microsoft.Extensions.Configuration" Version="9.0.1" />
<PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="9.0.1" />
Expand Down
16 changes: 0 additions & 16 deletions tests/Neo.Plugins.OracleService.Tests/Neo.Plugins.OracleService.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,6 @@
<ItemGroup>
<PackageReference Include="Akka.TestKit" Version="1.5.36" />
<PackageReference Include="MSTest" Version="$(MSTestVersion)" />

<!-- Following is the dependency tree from this project to BouncyCastle -->
<!-- OracleService.Tests.csproj
-> OracleService.csproj
-> NeoFS.API 3.5.0
-> BouncyCastle.NetCore 1.9.0
-> Neo.csproj
-> BouncyCastle.NetCore 2.2.1 -->
<!--
Note that BouncyCastle.NetCore 1.9.0 has assembly version of 1.9.0.0
While BouncyCastle.NetCore 2.2.1 has assembly version of 0.0.0.0
So, when NeoFS.API attempts to load BouncyCastle.Castle 1.9.0.0 assembly, it will fail because 0.0.0.0 is not compatible.
This used to work with VSTest before migrating to Microsoft.Testing.Platform because VSTest has an assembly resolver that ignores versions
The ideal fix there is to have a new version of NeoFS.API which is using BouncyCastle 2.2.1 and update NeoFS.API. Then, the package reference below is not needed
-->
<PackageReference Include="BouncyCastle.NetCore" Version="1.9.0" NoWarn="NU1605" />
Copy link
Member Author

@shargon shargon Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roman-khimov If we can't update the NeoFS library we should drop it

Copy link
Contributor

@roman-khimov roman-khimov Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's the problem with FS library here. Is it using the same wrong package? Then likely it can be fixed in https://github.com/neo-project/neofs-api-csharp in the same way.

</ItemGroup>

<ItemGroup>
Expand Down