Skip to content

[Fix] Fix big decimal GetHashCode #3963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

[Fix] Fix big decimal GetHashCode #3963

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad9a1b3
Fix BigDecimal
shargon May 25, 2025
0e88e27
Merge branch 'dev' into fix-big-decimal-hash-code
shargon May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Neo/BigDecimal.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,7 @@ public readonly bool Equals(BigDecimal other)

public override readonly int GetHashCode()
{
var divisor = BigInteger.Pow(10, _decimals);
var result = BigInteger.DivRem(_value, divisor, out var remainder);
return HashCode.Combine(result, remainder);
return HashCode.Combine(_decimals, _value.GetHashCode());
Copy link
Contributor

@Jim8y Jim8y May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but why previous logic? any specific reason?

Copy link
Member Author

@shargon shargon May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know

}

public static bool operator ==(BigDecimal left, BigDecimal right)
Expand Down