-
Notifications
You must be signed in to change notification settings - Fork 1k
[Fix]: ISigner Only sign consensus messages
#3939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix]: Only sign consensus messagesFix]: ISigner Only sign consensus messages
|
I don't see the problem of signany data, it should be the implementation who make the restrictions, so it should be good to have different methods for different kind of signatures |
If an attacker hacked a neo node that uses this sign service(If no this sign service, the attacker can get the privat key), the attacker can send a tx to the sign service, and if sign service sign this tx data, the assets will be transferred.
What is "different methods for different kind of signatures"? |
|
SignTransaction is not used now, so not added. |
src/Plugins/DBFTPlugin/Consensus/ConsensusContext.MakePayload.cs
Outdated
Show resolved
Hide resolved
vncoelho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
* Fix: make the signer sign specific data * Fix: make the signer sign specific data --------- Co-authored-by: Shargon <[email protected]> Co-authored-by: Vitor Nazário Coelho <[email protected]>
Description
Fix an issue found in #3896.
The current
ISignerinterface can sign any data and there is an issue if the data is a tranfer tx.This PR allows the signer to only sign consensus messages and block.
Fixes # (issue)
Type of change
Checklist: