[Optimization]: make some unit tests more readable
#3716
Merged
+136
−192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cschuchardt88
requested changes
Feb 5, 2025
| UInt256 val256 = UInt256.Zero; | ||
| TestUtils.SetupBlockWithValues(null, uut, val256, out var merkRootVal, out _, out var timestampVal, out var nonceVal, out var indexVal, out var scriptVal, out _, 0); | ||
|
|
||
| var uut = TestUtils.MakeBlock(null, UInt256.Zero, 0); |
There was a problem hiding this comment.
What happen to this unit test? Same for the others.
There was a problem hiding this comment.
What happen to this unit test? Same for the others.
Too many unused out variables.
It isn't clear.
There was a problem hiding this comment.
Ill have to download to it and look at it.
There was a problem hiding this comment.
Ill have to download to it and look at it.
SetupHeaderWithValues sets these out variables and header fields to same values.
So these Assert.AreEqual are meaningless.
Comment on lines
179
to
180
| InvocationScript = Array.Empty<byte>(), | ||
| VerificationScript = Array.Empty<byte>() |
There was a problem hiding this comment.
Suggested change
| InvocationScript = Array.Empty<byte>(), | |
| VerificationScript = Array.Empty<byte>() | |
| InvocationScript = [], | |
| VerificationScript = [], |
There was a problem hiding this comment.
InvocationScript
public ReadOnlyMemory<byte> InvocationScript;There was a problem hiding this comment.
ReadOnlyMemory<byte>.Empty or Memory<byte>.Empty
Jim8y
reviewed
Feb 6, 2025
Jim8y
previously approved these changes
Feb 6, 2025
shargon
reviewed
Feb 6, 2025
nan01ab
force-pushed
the
fix.ugly-unit-tests
branch
from
83f7862 to
ab4d7f7
Compare
Done |
shargon
previously approved these changes
Feb 6, 2025
shargon
approved these changes
Feb 6, 2025
cschuchardt88
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
TestUtils.SetupHeaderWithValuesandTestUtils.SetupBlockWithValuessimpler and clearerType of change
Checklist: