Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ut: fix HF_Echidna unit tests #3646

Open
wants to merge 4 commits into
base: HF_Echidna
Choose a base branch
from
Open

ut: fix HF_Echidna unit tests #3646

wants to merge 4 commits into from

Conversation

shargon
Copy link
Member

@shargon shargon commented Dec 27, 2024

Description

My bad, the previous code also checks in the executable folder.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Not changed

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

src/Neo/ProtocolSettings.cs Outdated Show resolved Hide resolved
src/Neo/ProtocolSettings.cs Outdated Show resolved Hide resolved
@Jim8y
Copy link
Contributor

Jim8y commented Dec 27, 2024

Nice work @shargon

Co-authored-by: Christopher Schuchardt <[email protected]>
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@@ -143,7 +179,9 @@ public static ProtocolSettings Load(Stream stream)
/// <returns>The loaded <see cref="ProtocolSettings"/>.</returns>
public static ProtocolSettings Load(string path)
{
if (!File.Exists(path))
path = FindFile(path, Environment.CurrentDirectory);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My primary concern here is that this code should be compatible with the old behaviour of neo-cli binary for production usage (default config.json file from the neo-cli binary dir will be used). From what I see, it's OK, but we'd better recheck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants