-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ut: fix HF_Echidna unit tests #3646
base: HF_Echidna
Are you sure you want to change the base?
Conversation
Co-authored-by: nan01ab <[email protected]>
Co-authored-by: nan01ab <[email protected]>
Nice work @shargon |
Co-authored-by: Christopher Schuchardt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM.
@@ -143,7 +179,9 @@ public static ProtocolSettings Load(Stream stream) | |||
/// <returns>The loaded <see cref="ProtocolSettings"/>.</returns> | |||
public static ProtocolSettings Load(string path) | |||
{ | |||
if (!File.Exists(path)) | |||
path = FindFile(path, Environment.CurrentDirectory); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My primary concern here is that this code should be compatible with the old behaviour of neo-cli
binary for production usage (default config.json
file from the neo-cli
binary dir will be used). From what I see, it's OK, but we'd better recheck.
Description
My bad, the previous code also checks in the executable folder.
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: