[Add] NeoToken to have 8 Decimals

[cschuchardt88]

Description

Added hardfork for old method Decimals value of 0 to now have 8 Decimals.

Change Log

• Added HardFork for old method of Decimals with 0 decimals.
• Added HardFork for new method of Decimals with 8 decimals.

Type of change

• Optimization (the change is only an optimization)
• Style (the change is only a code style for better maintenance or standard purpose)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Unit Tests

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[shargon]

You need to multiply the balance by the factor, or store version inside the AccountBalance

[AnnaShaleva]

Oh-oh, I thought that this proposal is still under discussion. It will break our economic model, it goes against NEP-17 standard and this change is harmful for the tools in Neo ecosystem that work with Neo token. We're against of this change.

[cschuchardt88]

I agree. Goes against the purpose of the Gas Token.

[roman-khimov]

You need to multiply the balance by the factor, or store version inside the AccountBalance

Think of bNEO balances as well that are stored in the respective contract. Or other contracts holding NEO. Or the meaning of

PUSHNULL
PUSH1
PUSHDATA1 ...to...
PUSHDATA1 ...from...
PUSH4
PACK
PUSH15
PUSHDATA1 7472616e73666572
PUSHDATA1 f563ea40bc283d4d0e05c48ea305b3f2a07340ef
SYSCALL System.Contract.Call

NEP-17 is not just paper, you can not change decimals that easy. Only with a new token and migration. And this new token will have to solve other problems as well (GAS is the main of them).