Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check script null in ContextItem #3198

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Check script null in ContextItem #3198

merged 1 commit into from
Apr 19, 2024

Conversation

shargon
Copy link
Member

@shargon shargon commented Apr 18, 2024

Close #3197

@shargon shargon requested a review from superboyiii April 18, 2024 08:34
superboyiii
superboyiii approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@superboyiii superboyiii left a comment •
edited by Jim8y
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, maybe add some UT? @shargon

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 18, 2024
@AnnaShaleva
smartcontract: ensure nil ParameterContext Item's script is marshallable
4b9024f 
Ensure that ParameterContext's Item with nil script can be properly
marshalled. Ref. neo-project/neo#3198.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva AnnaShaleva mentioned this pull request Apr 18, 2024
Merged
@shargon shargon merged commit 629baf8 into master Apr 19, 2024
5 of 6 checks passed
@shargon shargon deleted the core-fix-3197 branch April 19, 2024 07:30
AliceInHunterland pushed a commit to nspcc-dev/neo-go that referenced this pull request Apr 22, 2024
@AnnaShaleva @AliceInHunterland
smartcontract: ensure nil ParameterContext Item's script is marshallable
89edaa0 
Ensure that ParameterContext's Item with nil script can be properly
marshalled. Ref. neo-project/neo#3198.

Signed-off-by: Anna Shaleva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superboyiii superboyiii superboyiii approved these changes

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

@Jim8y Jim8y Jim8y approved these changes

@cschuchardt88 cschuchardt88 cschuchardt88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ContractParametersContext.ToJson() hasn't checked Script is null or not before Convert.ToBase64String(Script)
5 participants
@shargon @cschuchardt88 @Jim8y @AnnaShaleva @superboyiii