Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove net7.0 framework #3182

Merged
merged 9 commits into from
Mar 25, 2024
Merged

Conversation

cschuchardt88
Copy link
Member

Change Log

  • Removed net7.0 support

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the current errors on the containers for net8.0 I think it will be good to go.

Is this ready, @cschuchardt88 ?

Jim8y
Jim8y previously approved these changes Mar 25, 2024
This reverts commit 551f19e.
@cschuchardt88
Copy link
Member Author

Due to the current errors on the containers for net8.0 I think it will be good to go.

Is this ready, @cschuchardt88 ?

Ok ready

@shargon shargon merged commit b099b87 into neo-project:master Mar 25, 2024
6 checks passed
@cschuchardt88 cschuchardt88 deleted the dotnet-upgrade branch May 1, 2024 19:01
@roman-khimov roman-khimov added this to the v3.7.0 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants