-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Crypto Add] add secp256K1 Sign #3177
Conversation
Ok, macos, windows, ubuntu all have different behaviors,,,,, |
@shargon good to go now |
btw how to ensure the |
|
||
var curve = | ||
ecCurve == null || ecCurve == ECC.ECCurve.Secp256r1 ? ECCurve.NamedCurves.nistP256 : | ||
ecCurve == ECC.ECCurve.Secp256k1 ? ECCurve.CreateFromFriendlyName("secP256k1") : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about making the ECCurve.CreateFromFriendlyName("secP256k1")
a public static
property to allocate this object once, and then reuse it everywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe a cache system in another pr
Description
The issue is that the default C# dotnet does not support SECP256K1 curve on macos platform. We added support to SECP256K1 signature
verify
method for macos but did not add itssign
method.I found this issue when i was trying to run unit test here https://github.com/neo-project/neo-devpack-dotnet/blob/53a383ab5670d3c22d9761a113a50f7ef1a75ee0/tests/Neo.SmartContract.Framework.UnitTests/Services/CryptoTest.cs#L53
Fixes # (issue)
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: