Decouple calculate fee from Wallet #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
commented
Feb 18, 2024
|
@Jim8y merge? |
|
I did not remember that I created this issue...aheuaheuaea |
vncoelho
reviewed
Feb 22, 2024
vncoelho
approved these changes
Feb 22, 2024
|
It's an important public function maybe used by some plugins or elsewhere. The best practice is to keep that function and mark it obsolete instead of deleting it directly. Although this has been merged, I have to reminder that NEO N3 is a sophisticated blockchain now and we'd better providing compatibility to others as much as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #2354
Close #2352