Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ut #3113

Merged
merged 12 commits into from
Feb 6, 2024
Merged

Fix ut #3113

merged 12 commits into from
Feb 6, 2024

Conversation

shargon
Copy link
Member

@shargon shargon commented Feb 2, 2024

Close #3112

@shargon shargon requested a review from Jim8y February 2, 2024 12:48
@shargon shargon marked this pull request as ready for review February 2, 2024 12:57
@Jim8y
Copy link
Contributor

Jim8y commented Feb 2, 2024

LGTM

@Jim8y
Copy link
Contributor

Jim8y commented Feb 2, 2024

@superboyiii need you here

@shargon
Copy link
Member Author

shargon commented Feb 2, 2024

@superboyiii need you here

I prefer @superboyiii in #3082 :) here is fixed

@Jim8y
Copy link
Contributor

Jim8y commented Feb 3, 2024

Is that possible that you make the tiny methods in MemoryStore aggressiveinline here?

@superboyiii
Copy link
Member

Will test this when it's updated.

@Jim8y
Copy link
Contributor

Jim8y commented Feb 5, 2024

@shargon needs update

@Jim8y
Copy link
Contributor

Jim8y commented Feb 5, 2024

@cschuchardt88 @NGDAdmin

@shargon shargon merged commit a1291a6 into master Feb 6, 2024
1 of 2 checks passed
@shargon shargon deleted the fix-ut branch February 6, 2024 16:33
Jim8y added a commit to Jim8y/neo that referenced this pull request Feb 7, 2024
* master:
  Related to neo-project#3082 (comment) (neo-project#3119)
  [VM UT] update UT name (neo-project#3115)
  Neo as dotnet standard (neo-project#3082)
  Fix ut (neo-project#3113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UT random failure
3 participants