Fix: specify log exception. #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
Jan 13, 2024
| } | ||
| catch | ||
| { | ||
| throw new ArgumentException("Failed to convert byte array to string: Invalid or non-printable UTF-8 sequence detected.", nameof(state)); |
There was a problem hiding this comment.
I am not sure, cause user passes in bytes, if you show them hex, does that help at all?
There was a problem hiding this comment.
It's the message, both options are good for me
…to specify-log-exception * 'specify-log-exception' of github.com:Liaojinghui/neo: Update: list all existing pligins when checking plugin list, not just installed (neo-project#3080)
shargon
approved these changes
Jan 13, 2024
superboyiii
reviewed
Jan 18, 2024
| @@ -458,6 +458,7 @@ public virtual VerifyResult VerifyStateIndependent(ProtocolSettings settings) | |||
|
|
|||
| public StackItem ToStackItem(ReferenceCounter referenceCounter) | |||
| { | |||
| if (_signers == null || _signers.Length == 0) throw new ArgumentException("Sender is not specified in the transaction."); | |||
There was a problem hiding this comment.
Will this change fork something?
There was a problem hiding this comment.
No, it will still fault. Originally it fault, now it still fault, but fault with different exception, a more reasonable exception message.
shargon
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The RuntimeLog interface failed to speficy the exception message, though it takes arbitrary byte array as parameter, it only accept UTF8 sequence.
Fixes # (issue) #3088
Type of change
How Has This Been Tested?
Test Configuration:
Run TestInvalidUtf8LogMessage in UT_ApplicationEngine.Runtime.cs
Checklist: