Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to monorepo: Neo.Cryptography.BLS12_381 #3077

Merged
merged 7 commits into from
Jan 11, 2024
Merged

Move to monorepo: Neo.Cryptography.BLS12_381 #3077

merged 7 commits into from
Jan 11, 2024

Conversation

shargon
Copy link
Member

@shargon shargon commented Jan 10, 2024

@shargon shargon marked this pull request as ready for review January 10, 2024 08:53
@shargon shargon requested a review from Jim8y January 10, 2024 08:56
@Jim8y
Copy link
Contributor

Jim8y commented Jan 10, 2024

@cschuchardt88 can you please check if this is the latest?

@Jim8y
Copy link
Contributor

Jim8y commented Jan 10, 2024

@shargon do you mind to add an action that will run its unit test if C# code of this project is changed?

@shargon
Copy link
Member Author

shargon commented Jan 10, 2024

@shargon do you mind to add an action that will run its unit test if C# code of this project is changed?

Currently we run all the ut always

@cschuchardt88
Copy link
Member

@shargon do you mind to add an action that will run its unit test if C# code of this project is changed?

Test are ran by solution

dotnet test /p:CollectCoverage=true /p:CoverletOutputFormat=lcov /p:CoverletOutput=${GITHUB_WORKSPACE}/coverage/lcov

@cschuchardt88
Copy link
Member

@shargon Everything checks out

@shargon
Copy link
Member Author

shargon commented Jan 10, 2024

We can optimize the workflow in a different PR

@cschuchardt88
Copy link
Member

I replied to wrong to person. It was meant for @Jim8y

@shargon shargon merged commit 49ced83 into master Jan 11, 2024
2 checks passed
@shargon shargon deleted the move-bls branch January 11, 2024 05:53
Jim8y added a commit to Jim8y/neo that referenced this pull request Jan 12, 2024
* master:
  Made `MemoryStore` the default whithout `config.json` for `neo-cli` (neo-project#3085)
  Adding Devcontainer and link to codespace (neo-project#3075)
  Update & Consolidate nugets (neo-project#3083)
  Adding NNS to `neo-cli` (neo-project#3032)
  Add: add pull request template (neo-project#3081)
  Move to monorepo: Neo.Cryptography.BLS12_381 (neo-project#3077)
  Add: add a new verify result status code (neo-project#3076)
  Convert to Neo.Json and Neo.ConsoleService to `dotnet` standard 2.1 (neo-project#3044)
  Avoid IsExternalInit  (neo-project#3079)
  Clean usings (neo-project#3078)
  Fixed asp.net core project (neo-project#3067)
  Updated BLS12_381 (neo-project#3074)
  avoid nonsense exception messages. (neo-project#3063)
  Removed `MyGet` (neo-project#3071)
  Updated unit-test (neo-project#3073)
  add hash verification for OnImport (neo-project#3070)
  Make public ReadUserInput (neo-project#3068)
  Removed asp.net core (neo-project#3065)
  Enforce Line Endings in `.editorconfig` (neo-project#3060)

# Conflicts:
#	src/Neo.CLI/CLI/MainService.cs
@roman-khimov roman-khimov added this to the v3.7.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to monorepo
4 participants