Remove unnecessary default seedlist #2980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
previously approved these changes
Nov 21, 2023
vncoelho
previously approved these changes
Nov 21, 2023
|
I will fix try to fix the ut today, if @Liaojinghui can do it before, go ahead :) |
|
@shargon please check |
vncoelho
reviewed
Nov 21, 2023
| }, | ||
| MillisecondsPerBlock = 15000, | ||
| MaxTransactionsPerBlock = 512, | ||
| MemoryPoolMaxTransactions = 50_000, |
There was a problem hiding this comment.
maybe get the values that are still being set on [src/Neo/ProtocolSettings.cs]
…-seeds * 'remove-seeds' of github.com:neo-project/neo: Update TestProtocolSettings.cs
Jim8y
previously approved these changes
Nov 21, 2023
vncoelho
previously approved these changes
Nov 21, 2023
|
We remove code and no tests and the coverage decrease? |
|
More lines of code |
|
@shargon finally |
Jim8y
previously approved these changes
Nov 22, 2023
shargon
commented
Nov 22, 2023
shargon
commented
Nov 22, 2023
shargon
commented
Nov 22, 2023
AnnaShaleva
approved these changes
Nov 22, 2023
Jim8y
approved these changes
Nov 24, 2023
Jim8y
added a commit
to Jim8y/neo
that referenced
this pull request
Dec 31, 2023
* master: (30 commits) Set project as nullable (neo-project#3042) Fix: fix equal (neo-project#3028) Added README to packages (neo-project#3026) Nuget MyGet Fix (neo-project#3031) Add: print out the stack (neo-project#3033) fixed myget (neo-project#3029) Fixed MyGet Workflow (neo-project#3027) Package icons - hotfix (neo-project#3022) Nuget Package Icon & Symbols (neo-project#3020) Fix warning (neo-project#3021) Neo-node Migration (neo-project#2990) Remove unnecessary default seedlist (neo-project#2980) Fix Neo VM target frameworks (neo-project#2989) Update Neo.VM location in README.md (neo-project#2988) Migrating Neo VM (neo-project#2970) 3.6.2 (neo-project#2962) fix ut (neo-project#2959) Validate serialization during Contract deploy and Update (neo-project#2948) code optimization (neo-project#2958) check null scriptcontainer (neo-project#2953) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2772