Ensure nef file fit in vm

[shargon]

Following the line of neo-project/neo-vm#514

[shargon]

@Liaojinghui maybe we can just remove the constant and do this check in neo-devpack, otherwise, if it's not serialized/deserialized it won't happened. What do you think?

[Jim8y]

@Liaojinghui maybe we can just remove the constant and do this check in neo-devpack, otherwise, if it's not serialized/deserialized it won't happened. What do you think?

I dont think it matters, but you can do it and i will support you.

[AnnaShaleva]

@Liaojinghui maybe we can just remove the constant and do this check in neo-devpack, otherwise, if it's not serialized/deserialized it won't happened.

@shargon, could you, please, clarify the constant name you're talking about? If it's the ExecutionEngineLimits.Default.MaxItemSize, then I don't think we need to remove this check from the core library, because native Management contract uses this deserialisation code on contract deploy/update, and without this check presented in the core library we can still create an unwantedly large contract.

[shargon]

@Liaojinghui maybe we can just remove the constant and do this check in neo-devpack, otherwise, if it's not serialized/deserialized it won't happened.

@shargon, could you, please, clarify the constant name you're talking about? If it's the ExecutionEngineLimits.Default.MaxItemSize, then I don't think we need to remove this check from the core library, because native Management contract uses this deserialisation code on contract deploy/update, and without this check presented in the core library we can still create an unwantedly large contract.

MaxScriptSize

[AnnaShaleva]

maybe we can just remove the constant and do this check in neo-devpack

@shargon, I think it's a good idea to check the generated NEF file in the compiler against the size restrictions. I've implemented it in NeoGo, please, check the last two commits of https://github.com/nspcc-dev/neo-go/pull/3186/commits. If you're proposing something like this, then I support.

[shargon]

maybe we can just remove the constant and do this check in neo-devpack

@shargon, I think it's a good idea to check the generated NEF file in the compiler against the size restrictions. I've implemented it in NeoGo, please, check the last two commits of https://github.com/nspcc-dev/neo-go/pull/3186/commits. If you're proposing something like this, then I support.

Yes, is like this